Take the 2-minute tour ×
Server Fault is a question and answer site for professional system and network administrators. It's 100% free, no registration required.

I would like to control a bash script like this:

#!/bin/sh
USER1=_parsefromfile_
HOST1=_parsefromfile_
PW1=_parsefromfile_
USER2=_parsefromfile_
HOST2=_parsefromfile_
PW2=_parsefromfile_

imapsync \
--buffersize 8192000 --nosyncacls --subscribe --syncinternaldates --IgnoreSizeErrors \
--host1 $HOST1 --user1 $USER1 --password1 $PW1 --ssl1 --port1 993 --noauthmd5 \
--host2 $HOST2 --user2 $USER2 --password2 $PW2 --ssl2 --port2 993 --noauthmd5 --allowsizemismatch

with parameters from a control file like this:

host1 user1 password1 host2 user2 password2
anotherhost1 anotheruser1 anotherpassword1 anotherhost2 anotheruser2 anotherpassword2 

where each line represents one run of the script with the parameters extracted and made into variables.

what would be the most elegant way of doing this?

PAT

share|improve this question

3 Answers 3

up vote 1 down vote accepted

With shell scripts, this is normally accomplished using the source function, which executes the file as a shell script as if it was inlined into the script you're running -- which means that any variables you set in the file are exported into your script.

The downside is that (a) your config file is executed, so it's a security risk if unprivileged users can edit privileged config files. And (b) your config file syntax is restricted to valid bash syntax. Still, it's REALLY convenient.

config.conf

USER=joe
PASS=hello
SERVER=127.0.0.2

script.sh

#!/bin/bash

# Set defaults   
USER=`whoami`

# Load config values
source config.conf

foobar2000 --user=$USER --pass=$PASS --HOST=$HOST

source can be abbreviated with a single . -- so the following two are equivalent:

 source file.sh
 . file.sh
share|improve this answer
1  
I could be wrong, but I believe he wants to loop over options in a config file. I don't thing just using source will do what he wants. –  Zoredache Jan 6 '11 at 8:51
    
Yeah, I thought of source too but I think he doesn't want it that way. –  weeheavy Jan 6 '11 at 10:19
    
correct, the looping part is the important one, as i need to mass import some stuff.. –  perler Jan 6 '11 at 15:18

I think you should be using something like getopts if you want to make your script intelligent, instead of just trying to read your arguments on the number basis.

Something like this.

#!/bin/bash

while getopts ":a" opt; do
  case $opt in
    a)
      echo "-a was triggered!" >&2
      ;;
    \?)
      echo "Invalid option: -$OPTARG" >&2
      ;;
  esac
done


$ ./go_test.sh -a
-a was triggered!
$ 

You can parse arguments also. You can read more details about the tutorial over here.

share|improve this answer

Something like this. The important bit is using read to grab a line as an array.

#!/bin/bash
configfile=/pathtocontrolfile
cat $configfile | while read -a HR ; do

  [[ -z ${HR[0]} ]] && continue  # skip empty lines

  USER1=${HR[0]}
  HOST1=${HR[1]}
  PW1=${HR[2]}
  USER2=${HR[3]}
  HOST2=${HR[4]}
  PW2=${HR[5]}

  imapsync \
  --buffersize 8192000 --nosyncacls --subscribe --syncinternaldates --IgnoreSizeErrors \
  --host1 $HOST1 --user1 $USER1 --password1 $PW1 --ssl1 --port1 993 --noauthmd5 \
  --host2 $HOST2 --user2 $USER2 --password2 $PW2 --ssl2 --port2 993 --noauthmd5 --allowsizemismatch

done
share|improve this answer
    
+1 for making me look up the difference between [ and [[. (tldp.org/LDP/abs/html/testconstructs.html#DBLBRACKETS if the OP is interested.) Very useful. –  SmallClanger Jan 6 '11 at 9:35
2  
You could read directly into the variables: read -r USER1 HOST1 PW1 .... Note that -r should almost always be used (it allows backslashes to be read literally). Piping into while creates a subshell (which may not be a problem here). You can avoid that by redirecting the file into done: done < "$configfile". @SmallClanger: See also BashFAQ/031. –  Dennis Williamson Jan 6 '11 at 16:33
    
@Dennis Williamson, of course you are right, but the above was what I already had in a working script, please excuse the slight laziness. :) –  Zoredache Jan 6 '11 at 18:06
    
@Dennis Williamson - Ah, much clearer than the ABS. Thanks. Also, Ditto the read -r option. –  SmallClanger Jan 6 '11 at 18:30

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.